Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: exit add index on generated column with case-when expression parse error (#19330) #19395

Merged
merged 4 commits into from
Aug 26, 2020
Merged

ddl: exit add index on generated column with case-when expression parse error (#19330) #19395

merged 4 commits into from
Aug 26, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19330 to release-4.0

Signed-off-by: AilinKid [email protected]

What problem does this PR solve?

Issue Number: close #19325

What is changed and how it works?

check the ddl job cancel state on portal of adding index every turn.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • ddl: exit add index on generated column with case-when expression parse error

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Aug 24, 2020
Merged
@ti-srebot ti-srebot added this to the v4.0.6 milestone Aug 24, 2020
@AilinKid
.
d2c082e 
Signed-off-by: AilinKid <[email protected]>
zimulala
zimulala reviewed Aug 25, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2020
djshow832
djshow832 approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 25, 2020
@AilinKid
Copy link
Contributor

/run-all-tests

@AilinKid
Copy link
Contributor

/run-integration-copr-test

wjhuang2016
wjhuang2016 reviewed Aug 26, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Aug 26, 2020
@AilinKid
Copy link
Contributor

/run-integration-copr-test

@zimulala zimulala merged commit f22dc78 into pingcap:release-4.0 Aug 26, 2020
@AilinKid AilinKid deleted the release-4.0-1739f2af7743 branch August 26, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@zimulala zimulala zimulala left review comments

@djshow832 djshow832 djshow832 approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees

@AilinKid AilinKid

Labels
sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @AilinKid @zimulala @wjhuang2016 @djshow832